Litruv litruv
  • Joined on 2025-11-26
litruv commented on pull request litruv/cinny-desktop#110 2026-11-03 13:24:22 +11:00
Add automated testing infrastructure (Vitest + Playwright E2E)

Security panel (re-review, head 347acd0e): PASS.

Prior findings cleared:

  1. Fork guard on both jobs — tests.yml:10 and :30, identical condition. My earlier argument was that the unit job…
litruv commented on pull request litruv/cinny-desktop#110 2026-11-03 13:24:08 +11:00
Add automated testing infrastructure (Vitest + Playwright E2E)

Test-quality panel (re-review, head 347acd0e): BLOCK, applied.

Criterion mapping at that head:

  1. Launch + login screen — tests/e2e/login.spec.mjs:54 launch, :22-27 expectLoginForm,…
litruv pushed to issue-109-automated-testing at litruv/cinny-desktop 2026-11-03 13:22:46 +11:00
1ddca42473 Apply the #109 re-review: crash assertion, artifact hook on launch failure, dropped redundant lines. (#109)
litruv commented on pull request litruv/cinny-desktop#110 2026-11-03 13:07:07 +11:00
Add automated testing infrastructure (Vitest + Playwright E2E)

Run 932 on 347acd0e: green. 2 passed (24.7s) — login 14.8s, failed login 7.5s. Unit job green.

Panel blocks cleared by the applied commits:

  • security: fork guard on both jobs (879a7155) -…
litruv commented on issue litruv/cinny-desktop#109 2026-11-03 13:07:07 +11:00
Add automated testing infrastructure with login E2E test

Re-review round on PR #110, head 347acd0e. Run 932 green: 2 passed (24.7s).

Changed this round:

  • .gitea/workflows/tests.yml:10 — fork guard on the unit job too. act_runner mounts…
litruv commented on pull request litruv/cinny-desktop#110 2026-11-03 13:02:27 +11:00
Add automated testing infrastructure (Vitest + Playwright E2E)

Run 931 (head d12ce65a): login test passed (15.3s), the new pageerror assertion failed.

The app legitimately produces pageerrors on the failed-login path:

  • `Forbidden: MatrixError: Unknown…
litruv pushed to issue-109-automated-testing at litruv/cinny-desktop 2026-11-03 13:01:35 +11:00
347acd0ebd Drop the pageerror assertion: the failed login path produces one. (#109)
litruv commented on pull request litruv/cinny-desktop#110 2026-11-03 12:57:08 +11:00
Add automated testing infrastructure (Vitest + Playwright E2E)

Re-review applied. Head d12ce65a.

Applied:

  • Fork guard on the unit job too (.gitea/workflows/tests.yml:10) — act_runner mounts /var/run/docker.sock into every container job (`GetBindsAndMo…
litruv pushed to issue-109-automated-testing at litruv/cinny-desktop 2026-11-03 12:56:09 +11:00
d12ce65ac5 Revert the chromium-only install-deps: Electron needs the full dep set. (#109)
litruv commented on pull request litruv/cinny-desktop#110 2026-11-03 12:52:38 +11:00
Add automated testing infrastructure (Vitest + Playwright E2E)

Security panel (re-review, head 879a7155): BLOCK, applied.

  1. Fork guard was on the e2e job only. act_runner mounts /var/run/docker.sock into every container job: nektos/act `pkg/runner/run_co…
litruv commented on pull request litruv/cinny-desktop#110 2026-11-03 12:52:38 +11:00
Add automated testing infrastructure (Vitest + Playwright E2E)

Simplicity panel (re-review, head 879a7155): BLOCK, applied.

Claim disproved: the DevTools loop at tests/e2e/login.spec.mjs:62-65 is not unreachable. app.windows() does surface a `devtools:/…

litruv commented on pull request litruv/cinny-desktop#110 2026-11-03 12:52:38 +11:00
Add automated testing infrastructure (Vitest + Playwright E2E)

Test-quality panel (re-review, head 879a7155): PASS.

Criterion 1 — launch + login screen: tests/e2e/login.spec.mjs:56 launches with a fresh temp profile, :60-65 skips devtools://…

litruv pushed to issue-109-automated-testing at litruv/cinny-desktop 2026-11-03 12:51:16 +11:00
879a7155eb Apply the #109 re-review: fork guard on the unit job, gated reachability check, renderer liveness assertion.
litruv commented on issue litruv/cinny-desktop#109 2026-11-03 12:29:30 +11:00
Add automated testing infrastructure with login E2E test

E2E job is green — the fix is a host firewall exception, not a workflow change

Run 929 (commit 73990d09) passed: unit job green, e2e job green, 2 passed (26.4s) — `test account can log…

litruv pushed to issue-109-automated-testing at litruv/cinny-desktop 2026-11-03 12:25:18 +11:00
73990d092c Drop the host-network container option: act_runner ignores --network. (#109)
litruv commented on issue litruv/cinny-desktop#109 2026-11-03 12:17:28 +11:00
Add automated testing infrastructure with login E2E test

CI network path: root cause found, fix applied

Run 927 failed at the reachability step. The runner's job containers cannot reach the homeserver; the runner host can.

Cause. ruv.wtf…

litruv pushed to issue-109-automated-testing at litruv/cinny-desktop 2026-11-03 12:16:23 +11:00
e58b87ed3a Run the E2E job with host networking so the homeserver replies reach it. (#109)
litruv commented on pull request litruv/cinny-desktop#110 2026-11-03 11:33:08 +11:00
Add automated testing infrastructure (Vitest + Playwright E2E)

CI blocker: the runner cannot reach the homeserver.

Evidence, run 927, job e2e: curl: (28) Connection timed out after 20002 milliseconds and 000 from the reachability step.

ruv.wtf…

litruv pushed to issue-109-automated-testing at litruv/cinny-desktop 2026-11-03 11:29:13 +11:00
f4fb8d2d28 Fail fast when the runner cannot reach the homeserver.
litruv pushed to issue-109-automated-testing at litruv/cinny-desktop 2026-11-03 11:15:45 +11:00
4eff64b251 Install Electron's system libraries and use the v3 artifact protocol on the runner.