ci-check: eslint/react/no-danger #70

Closed
opened 2026-11-01 03:23:00 +11:00 by gitea-actions · 3 comments

eslint/react/no-danger: 1 violations.

eslint/react/no-danger	src/app/components/url-preview/TikTokEmbed.tsx:272
<!-- ci-check: eslint/react/no-danger --> <!-- ci-check-hash: 3e2278ca93424bb3363b0ee67ac1b6f1582f5715dace01a8656d0f63468d4653 --> `eslint/react/no-danger`: 1 violations. ```text eslint/react/no-danger src/app/components/url-preview/TikTokEmbed.tsx:272 ```
gitea-actions bot added the ci-checks label 2026-11-01 03:23:00 +11:00
Owner

Decision: accepted, not fixed. src/app/components/url-preview/TikTokEmbed.tsx:272 renders embed HTML from the TikTok oEmbed response through dangerouslySetInnerHTML. The payload is remote HTML with no structured field to render instead, so there is no cast-free or rule-free way to satisfy the rule. The rule stays on and this issue stays open as the record of that decision.

Decision: accepted, not fixed. `src/app/components/url-preview/TikTokEmbed.tsx:272` renders embed HTML from the TikTok oEmbed response through `dangerouslySetInnerHTML`. The payload is remote HTML with no structured field to render instead, so there is no cast-free or rule-free way to satisfy the rule. The rule stays on and this issue stays open as the record of that decision.

Fixed in f81461c.

Fixed in [f81461c](https://git.ruv.wtf/litruv/cinny/commit/f81461c0445974cbbaf5b901359121e5b87af21f).
gitea-actions bot closed this issue 2026-11-03 02:35:23 +11:00
Owner

Superseded — fixed at the site, not accepted. The TikTok embeds were removed entirely in 96d0d275: src/app/components/url-preview/TikTokEmbed.tsx and TikTokEmbed.css.tsx deleted, the barrel export dropped, and RenderMessageContent.tsx no longer special-cases TikTok URLs, so those links fall through to the generic preview. The rule is still on. The close comment names f81461c0 because that is the commit the checks run reported; the deletion itself is in 96d0d275.

Superseded — fixed at the site, not accepted. The TikTok embeds were removed entirely in `96d0d275`: `src/app/components/url-preview/TikTokEmbed.tsx` and `TikTokEmbed.css.tsx` deleted, the barrel export dropped, and `RenderMessageContent.tsx` no longer special-cases TikTok URLs, so those links fall through to the generic preview. The rule is still on. The close comment names `f81461c0` because that is the commit the checks run reported; the deletion itself is in `96d0d275`.
Sign in to join this conversation.
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: litruv/cinny#70