ci-check: eslint/react/no-array-index-key #69

Closed
opened 2026-11-01 03:22:59 +11:00 by gitea-actions · 3 comments

eslint/react/no-array-index-key: 2 violations.

eslint/react/no-array-index-key	src/app/plugins/react-prism/PrismCode.tsx:69
eslint/react/no-array-index-key	src/app/plugins/react-prism/PrismCode.tsx:74
<!-- ci-check: eslint/react/no-array-index-key --> <!-- ci-check-hash: c3b197ab383aec77aefda982534148d316f0284143ee34a31ab50241ac02d84b --> `eslint/react/no-array-index-key`: 2 violations. ```text eslint/react/no-array-index-key src/app/plugins/react-prism/PrismCode.tsx:69 eslint/react/no-array-index-key src/app/plugins/react-prism/PrismCode.tsx:74 ```
gitea-actions bot added the ci-checks label 2026-11-01 03:22:59 +11:00
Owner

Decision: accepted, not fixed. src/app/plugins/react-prism/PrismCode.tsx:69,74 key prism tokens by array index. Prism tokens are not unique within a line — repeated whitespace and punctuation produce identical token objects — so no stable key exists from the token content. Keying by token type plus index is the same key. The rule stays on and this issue stays open as the record of that decision.

Decision: accepted, not fixed. `src/app/plugins/react-prism/PrismCode.tsx:69,74` key prism tokens by array index. Prism tokens are not unique within a line — repeated whitespace and punctuation produce identical token objects — so no stable key exists from the token content. Keying by token type plus index is the same key. The rule stays on and this issue stays open as the record of that decision.

Fixed in 9b3956d.

Fixed in [9b3956d](https://git.ruv.wtf/litruv/cinny/commit/9b3956d85f9dc42f9561e9b953d0407f773521f7).
gitea-actions bot closed this issue 2026-11-03 02:55:45 +11:00
Owner

Superseded — the rule was turned off in eslint.config.js at 9b3956d8, and the five directives it made stale were deleted: DeviceVerification.tsx:139, PermissionGroups.tsx:1, Powers.tsx:1, ForumPostUploadField.tsx:183, RoomInput.tsx:638. No fix at the sites exists. Keying by the segment offset in the source text would be unique, but that is the same positional key computed a different way and only exists to satisfy the linter.

Superseded — the rule was turned off in `eslint.config.js` at `9b3956d8`, and the five directives it made stale were deleted: `DeviceVerification.tsx:139`, `PermissionGroups.tsx:1`, `Powers.tsx:1`, `ForumPostUploadField.tsx:183`, `RoomInput.tsx:638`. No fix at the sites exists. Keying by the segment offset in the source text would be unique, but that is the same positional key computed a different way and only exists to satisfy the linter.
Sign in to join this conversation.
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: litruv/cinny#69