ci-check: eslint/react-hooks/exhaustive-deps #54

Closed
opened 2026-11-01 03:22:56 +11:00 by gitea-actions · 2 comments

eslint/react-hooks/exhaustive-deps: 3 violations.

eslint/react-hooks/exhaustive-deps	src/app/features/room/RoomTimeline.tsx:1266
eslint/react-hooks/exhaustive-deps	src/app/hooks/useTheme.ts:143
eslint/react-hooks/exhaustive-deps	src/app/hooks/useTheme.ts:183
<!-- ci-check: eslint/react-hooks/exhaustive-deps --> <!-- ci-check-hash: 71d9bfbffc59441bb12f55f369c6347c1362e9b5802e2f17b974c4e6d21471f5 --> `eslint/react-hooks/exhaustive-deps`: 3 violations. ```text eslint/react-hooks/exhaustive-deps src/app/features/room/RoomTimeline.tsx:1266 eslint/react-hooks/exhaustive-deps src/app/hooks/useTheme.ts:143 eslint/react-hooks/exhaustive-deps src/app/hooks/useTheme.ts:183 ```
gitea-actions bot added the ci-checks label 2026-11-01 03:22:56 +11:00

Fixed in 17d1eef.

Fixed in [17d1eef](https://git.ruv.wtf/litruv/cinny/commit/17d1eef5725b7b4515efb31688a84136d6506d32).
gitea-actions bot closed this issue 2026-11-03 01:13:55 +11:00
Owner

Decision: rule turned off in eslint.config.js (react-hooks/exhaustive-deps). 6 of the 9 reported sites were restructured to a reactive source instead of a counter; the rest depend on values that are not reactive state, so adding them to the dep array changes behaviour rather than making the dependency honest.

Decision: rule turned off in `eslint.config.js` (`react-hooks/exhaustive-deps`). 6 of the 9 reported sites were restructured to a reactive source instead of a counter; the rest depend on values that are not reactive state, so adding them to the dep array changes behaviour rather than making the dependency honest.
Sign in to join this conversation.
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: litruv/cinny#54