ci-check: eslint/no-use-before-define #45

Closed
opened 2026-11-01 03:22:54 +11:00 by gitea-actions · 3 comments

eslint/no-use-before-define: 1 violations.

eslint/no-use-before-define	src/app/features/room-app/sanitizeRoomAppCss.ts:52
<!-- ci-check: eslint/no-use-before-define --> <!-- ci-check-hash: 3770e29d59cb15c369259578845dd37884c43f82afd6a134e442cc17d2303bc7 --> `eslint/no-use-before-define`: 1 violations. ```text eslint/no-use-before-define src/app/features/room-app/sanitizeRoomAppCss.ts:52 ```
gitea-actions bot added the ci-checks label 2026-11-01 03:22:54 +11:00
Owner

Decision: accepted, not fixed. src/app/features/room-app/sanitizeRoomAppCss.ts:52 is one of two mutually recursive const arrow functions. Satisfying the rule means hoisting one to a function declaration, which changes the file's style for no behavioural gain. The rule stays on and this issue stays open as the record of that decision.

Decision: accepted, not fixed. `src/app/features/room-app/sanitizeRoomAppCss.ts:52` is one of two mutually recursive const arrow functions. Satisfying the rule means hoisting one to a function declaration, which changes the file's style for no behavioural gain. The rule stays on and this issue stays open as the record of that decision.

Fixed in f81461c.

Fixed in [f81461c](https://git.ruv.wtf/litruv/cinny/commit/f81461c0445974cbbaf5b901359121e5b87af21f).
gitea-actions bot closed this issue 2026-11-03 02:35:23 +11:00
Owner

Superseded — fixed at the site, not accepted. The earlier decision assumed hoisting one arrow to a function declaration, which does not satisfy the rule because no-use-before-define runs with functions: true. f81461c0 merges rewriteBlock and rewriteCssChunk into one recursive rewriteChunk, so there is no forward reference. Output verified identical on 11 samples: plain rules, nested @media and @supports, @keyframes, @font-face, @import stripping, a brace-less rule, empty input, comma selector lists. The rule is still on.

Superseded — fixed at the site, not accepted. The earlier decision assumed hoisting one arrow to a function declaration, which does not satisfy the rule because `no-use-before-define` runs with `functions: true`. `f81461c0` merges `rewriteBlock` and `rewriteCssChunk` into one recursive `rewriteChunk`, so there is no forward reference. Output verified identical on 11 samples: plain rules, nested `@media` and `@supports`, `@keyframes`, `@font-face`, `@import` stripping, a brace-less rule, empty input, comma selector lists. The rule is still on.
Sign in to join this conversation.
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: litruv/cinny#45