Revert reporting the activity bar against the message in the viewport.
Trigger cinny-mobile / dispatch (push) Successful in 1s

The activity bar shows readers of the latest rendered event again. The scroll listener and the extra prop are gone.
This commit is contained in:
2026-10-31 23:51:34 +11:00
parent a6fac786b3
commit b294bb0c06
3 changed files with 8 additions and 42 deletions
+1 -31
View File
@@ -362,7 +362,6 @@ type RoomTimelineProps = {
eventId?: string;
roomInputRef: RefObject<HTMLElement>;
editor: Editor;
onViewportAnchorChange?: (eventId?: string) => void;
};
const PAGINATION_LIMIT = 80;
@@ -565,13 +564,7 @@ const getRoomUnreadInfo = (room: Room, scrollTo = false) => {
};
};
export function RoomTimeline({
room,
eventId,
roomInputRef,
editor,
onViewportAnchorChange,
}: RoomTimelineProps) {
export function RoomTimeline({ room, eventId, roomInputRef, editor }: RoomTimelineProps) {
const mx = useMatrixClient();
const useAuthentication = useMediaAuthentication();
const [hideActivity] = useSetting(settingsAtom, 'hideActivity');
@@ -1196,29 +1189,6 @@ export function RoomTimeline({
};
}, [room.roomId, eventId, persistTimelineScroll]);
// Report the message the user is actually looking at, so the activity bar
// reflects the shown message instead of the newest event in the room.
useEffect(() => {
if (!onViewportAnchorChange) return undefined;
const scrollEl = scrollRef.current;
if (!scrollEl) return undefined;
let raf = 0;
const report = () => {
window.cancelAnimationFrame(raf);
raf = window.requestAnimationFrame(() => {
onViewportAnchorChange(eventId ?? getViewportAnchorEventId() ?? getRangeCenterEventId());
});
};
report();
scrollEl.addEventListener('scroll', report, { passive: true });
return () => {
window.cancelAnimationFrame(raf);
scrollEl.removeEventListener('scroll', report);
};
}, [onViewportAnchorChange, eventId, getViewportAnchorEventId, getRangeCenterEventId]);
// Restore saved scroll or default to bottom on first open.
useLayoutEffect(() => {
const scrollEl = scrollRef.current;
+2 -4
View File
@@ -1,4 +1,4 @@
import React, { useCallback, useRef, useState } from 'react';
import React, { useCallback, useRef } from 'react';
import { Box, Text, config } from 'folds';
import { EventType, Room } from 'matrix-js-sdk';
import { ReactEditor } from 'slate-react';
@@ -65,7 +65,6 @@ export function RoomView({ room, eventId }: { room: Room; eventId?: string }) {
const roomViewRef = useRef<HTMLDivElement>(null);
const [hideActivity] = useSetting(settingsAtom, 'hideActivity');
const [viewportEventId, setViewportEventId] = useState<string>();
const { roomId } = room;
const editor = useEditor();
@@ -118,11 +117,10 @@ export function RoomView({ room, eventId }: { room: Room; eventId?: string }) {
eventId={eventId}
roomInputRef={roomInputRef}
editor={editor}
onViewportAnchorChange={setViewportEventId}
/>
<div className={roomViewCss.RoomViewBottomFloat}>
<RoomViewTyping room={room} />
{!hideActivity && <RoomViewFollowing room={room} eventId={viewportEventId} />}
{!hideActivity && <RoomViewFollowing room={room} />}
</div>
</Box>
<Box shrink="No" direction="Column">
+5 -7
View File
@@ -20,17 +20,15 @@ export function RoomViewFollowingPlaceholder() {
export type RoomViewFollowingProps = {
room: Room;
/** Message the user is looking at. Falls back to the latest rendered event. */
eventId?: string;
};
export const RoomViewFollowing = as<'div', RoomViewFollowingProps>(
({ className, room, eventId, ...props }, ref) => {
({ className, room, ...props }, ref) => {
const mx = useMatrixClient();
const myUserId = mx.getUserId();
const [open, setOpen] = useState(false);
const latestEvent = useRoomLatestRenderedEvent(room);
const shownEventId = eventId ?? latestEvent?.getId();
const latestEventReaders = useRoomEventReaders(room, shownEventId);
const eventId = latestEvent?.getId();
const latestEventReaders = useRoomEventReaders(room, eventId);
const names = latestEventReaders
.filter((readerId) => readerId !== myUserId)
@@ -44,7 +42,7 @@ export const RoomViewFollowing = as<'div', RoomViewFollowingProps>(
return (
<>
{shownEventId && (
{eventId && (
<Overlay open={open} backdrop={<OverlayBackdrop />}>
<OverlayCenter>
<FocusTrap
@@ -56,7 +54,7 @@ export const RoomViewFollowing = as<'div', RoomViewFollowingProps>(
}}
>
<Modal variant="Surface" size="300">
<EventReaders room={room} eventId={shownEventId} requestClose={() => setOpen(false)} />
<EventReaders room={room} eventId={eventId} requestClose={() => setOpen(false)} />
</Modal>
</FocusTrap>
</OverlayCenter>