Apply the #109 review panel: fork guard, loopback dev server, real authenticated assertions.
Playwright's webServer replaces the custom globalSetup. The e2e job is gated to same-repo PRs because a fork PR controls both the test files and the workflow steps while the E2E_PASSWORD secret is in the environment. The dev server is pinned to loopback, the login screen is asserted before filling, the authenticated state is proven by a token-authenticated request, the token value is never printed, the failed-login test no longer asserts a tautological exitCode, and the DevTools window is no longer mistaken for the app window.
This commit is contained in:
+1
-1
@@ -2,7 +2,7 @@ import { defineConfig } from 'vitest/config';
|
||||
|
||||
export default defineConfig({
|
||||
test: {
|
||||
// The default pattern would also pick up the Electron spec in tests/e2e.
|
||||
include: ['tests/unit/**/*.test.js'],
|
||||
environment: 'node',
|
||||
},
|
||||
});
|
||||
|
||||
Reference in New Issue
Block a user