Apply the #109 review panel: fork guard, loopback dev server, real authenticated assertions.
Tests / unit (pull_request) Successful in 17s
Tests / e2e (pull_request) Failing after 1m1s

Playwright's webServer replaces the custom globalSetup. The e2e job is gated to same-repo PRs because a fork PR controls both the test files and the workflow steps while the E2E_PASSWORD secret is in the environment. The dev server is pinned to loopback, the login screen is asserted before filling, the authenticated state is proven by a token-authenticated request, the token value is never printed, the failed-login test no longer asserts a tautological exitCode, and the DevTools window is no longer mistaken for the app window.
This commit is contained in:
2026-11-03 11:04:18 +11:00
parent 348e47dbd8
commit fcbf1020e8
6 changed files with 69 additions and 82 deletions
+2 -1
View File
@@ -40,7 +40,8 @@ The E2E test drives the real Electron app against the vite dev server, so it nee
cinny dependencies installed and an X display. On a headless machine run it under xvfb:
`xvfb-run -a npm run test:e2e`.
The login test uses a dedicated test account, never a personal one:
The E2E test logs in to a live homeserver over the network, so it needs network access and a
working test account. It uses a dedicated account, never a personal one:
Variable | Default
---|---