Apply the #109 re-review: crash assertion, artifact hook on launch failure, dropped redundant lines. (#109)
tests/e2e/login.spec.mjs: assert the render process is alive with the `crash` event instead of counting pageerrors; the failed-login test now accepts the rate-limited message as well as the wrong-password one; the failure hook attaches the console before the app guard so a launch failure still produces an artifact, wraps `screenshot()` because it throws on a crashed page, and reaches `fs.rmSync` on launch failure; dropped the duplicate login-form assertion. playwright.config.mjs: pin `trace: 'off'` explicitly rather than relying on the version default, since a trace captures the login POST body. .gitea/workflows/tests.yml: dropped `--prefer-offline`; corrected the xvfb comment (the guard is live for the host runner, which already has xvfb); dropped an unresolvable CI run-number citation. Checks: `node --check` on both JS files, `npm run test:unit` — 2 passed. E2E cannot be run locally (no `E2E_PASSWORD` in this session); CI is the check.
This commit is contained in:
@@ -58,17 +58,19 @@ jobs:
|
||||
# The E2E run drives the vite dev server, so cinny's dependencies are needed too.
|
||||
- name: Install dependencies (cinny)
|
||||
working-directory: ./cinny
|
||||
run: npm ci --prefer-offline
|
||||
run: npm ci
|
||||
|
||||
# Electron needs system libraries the runner image does not ship. Do not narrow this to
|
||||
# chromium: Playwright's chromium dep set covers its own bundled browser, not Electron,
|
||||
# and drops libgtk-3-0t64, libegl1, libegl-mesa0, libgles2, libsecret-1-0, libxtst6 and
|
||||
# libxss1, which Electron needs to launch. Run 930 failed with "Process failed to launch!"
|
||||
# on the narrowed set.
|
||||
# libxss1, which Electron needs to launch. Narrowing it fails with "Process failed to
|
||||
# launch!".
|
||||
- name: Install system libraries for Electron
|
||||
run: npx playwright install-deps
|
||||
|
||||
# The runner image has no xvfb and no fresh apt lists.
|
||||
# The container runner image has no xvfb and no fresh apt lists. The host runner already
|
||||
# has xvfb, so the guard skips the install there; both share the ubuntu-latest label, so
|
||||
# which one runs is not fixed.
|
||||
- name: Ensure a display for Electron
|
||||
run: command -v xvfb-run >/dev/null || (sudo apt-get update && sudo apt-get install -y xvfb)
|
||||
|
||||
|
||||
Reference in New Issue
Block a user